refactor: avoid unneeded initializations in injection contexts #2950
+103
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Laprun <[email protected]>
xstefank
approved these changes
Sep 18, 2025
|
Can we merge this, @csviri? |
csviri
reviewed
Sep 19, 2025
|
|
||
| private void init(ConfigurationService configurationService, boolean allowDeferredInit) { | ||
| if (configurationService == null) { | ||
| if (!allowDeferredInit) { |
There was a problem hiding this comment.
Can we add a unit test for this?
There was a problem hiding this comment.
Added a test, though it's not great and additional documentation, along with a protected method for subclasses to set the configuration service after intialization, if needed.
csviri
approved these changes
Sep 19, 2025
Signed-off-by: Chris Laprun <[email protected]>
csviri
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Laprun [email protected]